OpenSSL::TestASN1 regression

[mkristian]

test_decode:
OpenSSL::ASN1::ASN1Error: DER length more than 4 bytes: 126
org/jruby/ext/openssl/ASN1.java:1133:in decode' test/externals/ruby1.9/openssl/test_asn1.rb:176:intest_decode'

test_primitive_cannot_set_infinite_length:
[test/externals/ruby1.9/openssl/test_asn1.rb:237]:
Could set infinite length on primitive value

also see end of https://s3.amazonaws.com/archive.travis-ci.org/jobs/43629181/log.txt

[kares]

yep this one I got stuck on ...

I "improved" (at least I think I did) ASN1 handling internally, even got it working for all BCs.

I recall I hit the limits of BC's APIs but was able to get most relevant composites such as ASN1 Sequence/Set ~ right (where not working with infinite lengths previously) - but than this blowed in my face. it kind of seemed like a special handling for a special case, for one imp (can't recall if JRuby or MRI) it's double wrapped in a bit-string for the other it's one less wrapping. really not sure how it could have worked before ;( or there's the other case of me missing something :) !

this definitely needs dedicated time ...

[kares]

also I do see another ASN1 test failure as well :

  1) Error:
test_decode(OpenSSL::TestASN1):
OpenSSL::ASN1::ASN1Error: DER length more than 4 bytes: 126
    org/jruby/ext/openssl/ASN1.java:1098:in `decode'
    /home/kares/workspace/oss/jruby/test/externals/ruby1.9/openssl/test_asn1.rb:176:in `test_decode'

  2) Failure:
test_primitive_cannot_set_infinite_length(OpenSSL::TestASN1) [/home/kares/workspace/oss/jruby/test/externals/ruby1.9/openssl/test_asn1.rb:237]:
Could set infinite length on primitive value

... (simple) fix landing on master

[mkristian]

@kares I looked at a few certificates from rubygems/ssl_cert and they all have those
OCTET STRING, encapsulates { OCTET STRING
the rfc itself is not clear to me: https://www.ipa.go.jp/security/rfc/RFC3280-04EN.html#42102
so the sample CA certificates are the reference for this.

the jruby test needs some adjustments to work, but the actual test will pass now

[kares]

@mkristian you're the man! ... really do not know why I might have changed that - but if all pass no worries