IO#set_encoding should return self (fixes #4712)

jruby · Jul 11, 2017 · 4d1db6f · 4d1db6f
1 parent 36e97c6
commit 4d1db6f
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 4 deletions.
diff --git a/core/src/main/java/org/jruby/RubyIO.java b/core/src/main/java/org/jruby/RubyIO.java
@@ -1058,7 +1058,7 @@ public IRubyObject internal_encoding(ThreadContext context) {
     public IRubyObject set_encoding(ThreadContext context, IRubyObject encodingObj) {
         setEncoding(context, encodingObj, context.nil, context.nil);
 
-        return context.nil;
+        return this;
     }
 
     @JRubyMethod
@@ -1070,14 +1070,14 @@ public IRubyObject set_encoding(ThreadContext context, IRubyObject encodingStrin
             setEncoding(context, encodingString, internalEncoding, context.nil);
         }
 
-        return context.nil;
+        return this;
     }
 
     @JRubyMethod
     public IRubyObject set_encoding(ThreadContext context, IRubyObject encodingString, IRubyObject internalEncoding, IRubyObject options) {
         setEncoding(context, encodingString, internalEncoding, options);
 
-        return context.nil;
+        return this;
     }
 
     // mri: io_encoding_set

diff --git a/spec/tags/ruby/core/io/set_encoding_tags.txt b/spec/tags/ruby/core/io/set_encoding_tags.txt