Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

repackage all jnr-* dependencies to make jruby-core to be used in OSGi setup #3821

Closed
mkristian opened this issue Apr 21, 2016 · 7 comments
Closed

Comments

@mkristian
Copy link
Member

Environment

any jruby-9k version

Expected Behavior

be able to create osgi package out of jruby-core on the fly or even setup working osgi metadata for jruby-core

Actual Behavior

can not find classes which are repacked by jruby but declared in the osgi metadata of the respective jnr-xyz jar.

@headius
Copy link
Member

headius commented Aug 22, 2016

@mkristian I'm going to remove this from any release since it's not clear when it will happen.

@headius headius removed this from the JRuby 9.1.3.0 milestone Aug 22, 2016
@mkristian
Copy link
Member Author

@headius I hope the repackaging I meant the java packages and shade them ALL into the jruby-core. doing so for jruby-9.2.x would be worth give it a thought

@headius
Copy link
Member

headius commented Aug 24, 2016

@mkristian By shade, you mean take all of our internal dependencies and relocate them into JRuby packages, yes? That would be fine with me, if it doesn't impact build times too much. And any API that we expose, like date/time classes accepting or returning Joda's DateTime, would still need to be unshaded.

9.2 seems like a reasonable timeframe to consider this.

@headius
Copy link
Member

headius commented May 15, 2018

Ping @mkristian. We need to address this or retarget (probably retarget).

@headius headius removed this from the JRuby 9.2.0.0 milestone May 16, 2018
@headius
Copy link
Member

headius commented May 16, 2018

Too big a change to do right before release, according to @mkristian. I'll detarget until we can get this on a roadmap.

@headius
Copy link
Member

headius commented Jul 18, 2020

We have discussed this in other contexts and this bug is old and stale.

@headius headius closed this as completed Jul 18, 2020
@headius headius added this to the Invalid or Duplicate milestone Jul 18, 2020
@headius
Copy link
Member

headius commented Jul 18, 2020

See for example #6205.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants