Join GitHub today
GitHub is home to over 31 million developers working together to host and review code, manage projects, and build software together.Sign up
Update ERB stdlib from MRI 2.5.0 to at least 2.5.1 #5479
jruby 126.96.36.199 (2.5.0) 2018-11-13 8faff06 Java HotSpot(TM) 64-Bit Server VM 10.0.1+10 on 10.0.1+10 +jit [darwin-x86_64]
JRuby 188.8.131.52 uses the stdlib version of ERB from MRI 2.5.0. Unfortunately, that version introduced a backwards-incompatible change, as documented in https://redmine.ruby-lang.org/issues/14243. The change was reverted in MRI 2.5.1.
FWIW I tried the current trunk version of ERB instead and it seemed to work fine with JRuby 184.108.40.206.
I'm not sure what the JRuby policy is for updating the stdlib, but I'm guessing it's to match the compatibility version that's reported with
So I suppose this ticket is just a little bit of motivation to update to the latest 2.5.x stdlib :)
@presidentbeef So you're saying that 2.5.1 has the fix? I agree, we should do a stdlib update for 9.2.6 (9.2.5 already has a lot of fixes in it) to the latest 2.5.x stdlib.
Need to figure out a better policy here...maybe I can get our patches into the MRI repo so we can just source stdlib directly from.there.