Update stdlib to Ruby 2.5.3. #5505
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
headius
force-pushed
the
update_stdlib_2.5
branch
from
5b964e2
to
bd27274
Compare
ahorek
reviewed
Dec 11, 2018
| @initialized = false | ||
| end | ||
|
|
||
| def lazy_initialize |
There was a problem hiding this comment.
just for confirmation, this was backported to ruby 2.3, 2.4 and 2.6?
isn't 2.5 also affected?
see https://bugs.ruby-lang.org/issues/14571 and #5074
There was a problem hiding this comment.
Yes, this was originally filed against 2.5 it appears and backported as far as 2.3.
There was a problem hiding this comment.
yeah, but this change reverts the fix. Maybe MRI guys forgot to backport it?
kares
added a commit
to kares/jruby
that referenced
this pull request
Dec 11, 2018
- pass String instance (when possible) directly to unpack - or retrieved array elements should affect created string related to jrubyGH-5505
kares
added a commit
to kares/jruby
that referenced
this pull request
Dec 11, 2018
- pass String instance (when possible) directly to unpack - or retrieved array elements should affect created string related to jrubyGH-5505
kares
reviewed
Dec 11, 2018
| @@ -857,4 +860,20 @@ def test_unpack1 | |||
| assert_equal "hogefuga", "aG9nZWZ1Z2E=".unpack1("m") | |||
| assert_equal "01000001", "A".unpack1("B*") | |||
| end | |||
|
|
|||
| def test_pack_infection | |||
This is a new test for ARGV tainting that we never would have passed, because we don't taint ARGV strings. Note that MRI always taints all strings that come from "external" bytes, which is similar to our "external" Java strings. We are opting to localize this fix to ARGV only due to the unknown impact of suddenly tainting all strings imported from Java via our version of the "external" string construction. https://bugs.ruby-lang.org/issues/14941
… super is actually invoked. Therefore we cannot assume any argument which we think we need to splat is actually in need of splatting. Simple instanceof checks solves it. MRI core tests caught this in stdlib update to 2.5.4.
IRWrappedLambdaReturnValue exception coming out because END blocks are internally modelled as closures. This change also changed this exception to know whether it had been initiated by break or return.
…ine. Addresses MRI test.
so that "\u{0D 0A}" ends up as a single point.
This also updates Ruby compat version to run post-2.5.1 specs for this behavior. https://bugs.ruby-lang.org/issues/14380
headius
force-pushed
the
update_stdlib_2.5
branch
from
04c3b9b
to
abe5c19
Compare
… is way more important
…pagate potential taintedness.
Closed
These tests were imported with jruby#5505 and will be reenabled once
|
The final completed build failed because an earlier exclude was accidentally removed. I am merging after having restored that tag. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.