Actually use Java7ClassValue when using Java 7+. #1616
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
headius
added a commit
that referenced
this pull request
Apr 16, 2014
Actually use Java7ClassValue when using Java 7+.
|
Thanks! |
|
This should be included into jruby-1_7 branch as well, right? |
|
@cky jruby-1_7 is preferred for 1.8, 1.9+ compat fixes and other non-risky backwards compatible changes. If there is any risk or if public signatures change then master is a better place. It sounds like this could have went to jruby-1_7 as well. Don't sweat it though we are used to moving stuff around across branches... |
|
I cherry-picked it to jruby-1_7 here: f1d3620 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When f5850a5 was created, the
org.jruby.java.proxies.ClassValueProxyCacheclass was renamed asorg.jruby.util.collections.Java7ClassValue. But that class was only referenced via reflection, and so IDE-based refactoring did not catch it, andJava7ClassValueended up being totally unused.