Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Truffle] Fixing Symbol#<=>, Implementing Symbol Methods #2622

Merged
merged 1 commit into from Feb 26, 2015

Conversation

bjfish
Copy link
Contributor

@bjfish bjfish commented Feb 26, 2015

Fixing Symbol#<=>, Implementing Symol#capitalize, Symbol#casecmp, Symbol#downcase, Symbol#encoding, Symbol#intern

…secmp, Symbol#downcase, Symbol#encoding, Symbol#intern
chrisseaton added a commit that referenced this issue Feb 26, 2015
[Truffle] Fixing Symbol#<=>, Implementing Symbol Methods
@chrisseaton chrisseaton merged commit 2056137 into jruby:master Feb 26, 2015
1 check failed
@chrisseaton
Copy link
Contributor

@chrisseaton chrisseaton commented Feb 26, 2015

These changes have caused a failure in our FindBugs tests - https://travis-ci.org/jruby/jruby/jobs/52340101#L506-L508.

Normally I wouldn't bother you with that as you weren't to know it was there, but since you seem interested in committing quality code I'll involve you in that part of our testing infrastructure. Could you take a look? They look simple.

@bjfish
Copy link
Contributor Author

@bjfish bjfish commented Feb 26, 2015

@chrisseaton I can take a look at these. Is there a command I should run locally before check in?

@chrisseaton
Copy link
Contributor

@chrisseaton chrisseaton commented Feb 26, 2015

Oh yeah sorry, it's, function jt { ruby tool/jt.rb $@; } and then jt findbugs. JT is our Truffle specific build tool and has various useful things. https://github.com/jruby/jruby/blob/master/tool/jt.rb.

nirvdrum
Copy link
Contributor

@nirvdrum nirvdrum commented on 6b8e821 Feb 27, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FYI, method names in Java should be camel-cased. In this case caseCompareNode. Using Pascal case was triggering a failure in FindBugs. Taking it a step further, the operation should just be the verb part, dropping the noun (Node), making the method caseCompare. I fixed this in 3485ab6.

nirvdrum
Copy link
Contributor

@nirvdrum nirvdrum commented on 6b8e821 Feb 27, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Having said that, I see you followed those conventions elsewhere, so apologies for the mini-lecture for what was likely just a copy-and-paste issue.

bjfish
Copy link
Contributor Author

@bjfish bjfish commented on 6b8e821 Feb 27, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the tips. I'll run jt findbugs before pull requests now.

nirvdrum
Copy link
Contributor

@nirvdrum nirvdrum commented on 6b8e821 Feb 27, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's part of Travis, so if we let the build complete before merging the PR, it should get caught. Of course, running locally would reduce the feedback loop for you.

nirvdrum
Copy link
Contributor

@nirvdrum nirvdrum commented on 6b8e821 Feb 27, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

And thanks again for the contribution! Feel free to ask questions in IRC if you'd like help. I'm not sure if you saw, but we now have spec coverage reports:

https://github.com/jruby/jruby/wiki/Truffle#current-status

That gives a pretty good overview of the holes we currently have. It might be worth asking on IRC before tackling anything big (if you want to) just to make sure it's not in-progress elsewhere.

@nirvdrum
Copy link
Contributor

@nirvdrum nirvdrum commented Feb 27, 2015

And now I see I missed the previous discussion about FindBugs. Oops. I was looking at the code/commit comments, not the PR comments. It looks like you're on your way now.

@chrisseaton chrisseaton added this to the truffle-dev milestone May 4, 2015
@chrisseaton chrisseaton added this to the truffle-dev milestone May 4, 2015
@chrisseaton chrisseaton removed this from the truffle-dev milestone May 4, 2015
@chrisseaton chrisseaton removed this from the truffle-dev milestone May 4, 2015
@chrisseaton chrisseaton added this to the truffle-dev milestone May 4, 2015
@chrisseaton chrisseaton added this to the truffle-dev milestone May 4, 2015
@enebo enebo added this to the Non-Release milestone Dec 7, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants