Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Truffle] Fixing Symbol#<=>, Implementing Symbol Methods #2622

merged 1 commit into from Feb 26, 2015


Copy link

@bjfish bjfish commented Feb 26, 2015

Fixing Symbol#<=>, Implementing Symol#capitalize, Symbol#casecmp, Symbol#downcase, Symbol#encoding, Symbol#intern

…secmp, Symbol#downcase, Symbol#encoding, Symbol#intern
chrisseaton added a commit that referenced this pull request Feb 26, 2015
[Truffle] Fixing Symbol#<=>, Implementing Symbol Methods
@chrisseaton chrisseaton merged commit 2056137 into jruby:master Feb 26, 2015
Copy link

These changes have caused a failure in our FindBugs tests -

Normally I wouldn't bother you with that as you weren't to know it was there, but since you seem interested in committing quality code I'll involve you in that part of our testing infrastructure. Could you take a look? They look simple.

Copy link
Contributor Author

bjfish commented Feb 26, 2015

@chrisseaton I can take a look at these. Is there a command I should run locally before check in?

Copy link

Oh yeah sorry, it's, function jt { ruby tool/jt.rb $@; } and then jt findbugs. JT is our Truffle specific build tool and has various useful things.

Copy link

And now I see I missed the previous discussion about FindBugs. Oops. I was looking at the code/commit comments, not the PR comments. It looks like you're on your way now.

@chrisseaton chrisseaton modified the milestone: truffle-dev May 4, 2015
@enebo enebo added this to the Non-Release milestone Dec 7, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet
None yet

Successfully merging this pull request may close these issues.

None yet

4 participants