Join GitHub today
GitHub is home to over 20 million developers working together to host and review code, manage projects, and build software together.
get zone from RubyTime (fixes #3303) #3309
Conversation
tdaitx
closed this
Sep 8, 2015
tdaitx
reopened this
Sep 8, 2015
|
Perhaps we could just abstract the 0:00 to UTC logic into a separate method both call? Like |
tdaitx
referenced this pull request
Sep 15, 2015
Merged
Fix 3303 refactor zoneHelper into getRubyTimeZoneName #3331
|
Closing as a new proposal has been submitted (#3331). |
tdaitx
closed this
Sep 15, 2015
kares
added this to the Invalid or Duplicate milestone
Sep 17, 2015
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
tdaitx commentedSep 4, 2015
According to the spec
spec/ruby/core/time/strftime_spec.rb"%Z" and RubyTime#zone should behave the same:This fixes #3303 by calling RubyTime#zone directly.