Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test define method visibility #3873

merged 5 commits into from May 11, 2016

Test define method visibility #3873

merged 5 commits into from May 11, 2016


Copy link

@headius headius commented May 11, 2016

Fixes for #3854 and a few others, perhaps.

The rules are spelled out in a comment and abbreviated here:

* Paths expanded by the system, like ~, get 'filesystem' encoding
* Calls given a relative dir use that string's encoding
* Otherwise, use input string's encoding.

This improves specs by removing one tag, and passes three new
specs. We still have a couple outstanding tags here, though.

Fixes #3854.
@headius headius added this to the JRuby milestone May 11, 2016

klass.should have_public_instance_method(:bar)
klass.should have_public_instance_method(:baz)
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.


@headius headius merged commit 396a00c into master May 11, 2016
@headius headius deleted the test-define_method-visibility branch May 11, 2016 15:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet
None yet

Successfully merging this pull request may close these issues.

None yet

2 participants