New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test define method visibility #3873

Merged
merged 5 commits into from May 11, 2016

Conversation

Projects
None yet
2 participants
@headius
Member

headius commented May 11, 2016

Fixes for #3854 and a few others, perhaps.

headius added some commits May 11, 2016

Attempt to emulate MRI rules for when to use the frame's visbility
The rules are spelled out in a comment and abbreviated here:

* Paths expanded by the system, like ~, get 'filesystem' encoding
* Calls given a relative dir use that string's encoding
* Otherwise, use input string's encoding.

This improves specs by removing one tag, and passes three new
specs. We still have a couple outstanding tags here, though.

Fixes #3854.

@headius headius added this to the JRuby 9.1.1.0 milestone May 11, 2016

end
klass.should have_public_instance_method(:bar)
klass.should have_public_instance_method(:baz)

This comment has been minimized.

@eregon

eregon May 11, 2016

Member

👍

@headius headius merged commit 396a00c into master May 11, 2016

1 of 4 checks passed

continuous-integration/appveyor/branch AppVeyor build failed
Details
continuous-integration/appveyor/pr AppVeyor build failed
Details
continuous-integration/travis-ci/push The Travis CI build failed
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@headius headius deleted the test-define_method-visibility branch May 11, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment