Flag registry #3938
Merged
Flag registry #3938
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This implementation expects ancestors to register their flags first, ensuring they are packed tightly. The rest of the logic makes sure that no child overlaps any parent, and the flags are calculated based on the nearest flag-registering parent's last shift value. There's an additional piece of work here: rewrite the Constants class so that instead of calculating these flags at runtime, it just has the literal calculated flag values, so they can be folded into all places where they are called. See the hacky assertion in StringSupport for a reason why this would be better. Note that OpenJDK 7 and higher *will* fold runtime-calculated static final values when jitting, so performance wise this additional improvement would mostly just simplify javac-emitted bytecode and possibly improve the performance of interpreted bytecode *slightly*.
|
FWIW, despite having flag values in RubyBasicObject up to the tenth bit, we only end up using the following values: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
tldr: this is a registry for all flags we use against Ruby objects in JRuby. The goal is to maximize utilization of the flags and ensure we do not overlap.
See the first commit and the doco for FlagRegistry.
My intent with this is to begin exploring more specialized subclasses of key Ruby core classes. For example, we might want to have a RubyArrayOne that only holds one value initially in a field rather than an array. If it grows, we would set a "failed" flag that would indicate we need to fall back to using the values array rather than the one field. Rather than putting this as a boolean on the class, increasing object size, we can use flags. But I wanted a better mechanism to ensure I'm not overlapping other flags higher in the hierarchy, as our use of them broadens.