New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Java's Arrays.sort #3961

Merged
merged 2 commits into from Jun 15, 2016

Conversation

Projects
None yet
3 participants
@sri
Contributor

sri commented Jun 9, 2016

Java's Arrays.sort more robust and is faster is certain cases.

See #3919 and
https://github.com/sri/jruby-sort-benchmark.

Use Java's Arrays.sort
Java's Arrays.sort more robust and is faster is certain cases.

See #3919 and
https://github.com/sri/jruby-sort-benchmark.
@enebo

This comment has been minimized.

Show comment
Hide comment
@enebo

enebo Jun 14, 2016

Member

@sri could you re-add the util class and @deprecate it at the top. I do not know if extensions use that class or not but it is public.

Member

enebo commented Jun 14, 2016

@sri could you re-add the util class and @deprecate it at the top. I do not know if extensions use that class or not but it is public.

@sri

This comment has been minimized.

Show comment
Hide comment
@sri

sri Jun 15, 2016

Contributor

@enebo Done!

Contributor

sri commented Jun 15, 2016

@enebo Done!

@enebo enebo merged commit f434a33 into jruby:master Jun 15, 2016

0 of 2 checks passed

continuous-integration/appveyor/pr AppVeyor build failed
Details
continuous-integration/travis-ci/pr The Travis CI build failed
Details
@enebo

This comment has been minimized.

Show comment
Hide comment
@enebo

enebo Jun 15, 2016

Member

@sri thanks for the PR and the time taken to show Java's sort has improved!

Member

enebo commented Jun 15, 2016

@sri thanks for the PR and the time taken to show Java's sort has improved!

@chrisseaton

This comment has been minimized.

Show comment
Hide comment
@chrisseaton

chrisseaton Jun 15, 2016

Contributor

What is the reason behind this commit? It adds a new class, but then deprecates it at the same time.

Contributor

chrisseaton commented on 192f7a3 Jun 15, 2016

What is the reason behind this commit? It adds a new class, but then deprecates it at the same time.

This comment has been minimized.

Show comment
Hide comment
@enebo

enebo Jun 15, 2016

Member

He removed in a previous commit in the same PR. I guess it all works out in the end :)

Member

enebo replied Jun 15, 2016

He removed in a previous commit in the same PR. I guess it all works out in the end :)

@sri

This comment has been minimized.

Show comment
Hide comment
@sri

sri Jun 16, 2016

Contributor

@enebo Great! Thanks for all the pointers!!

Contributor

sri commented Jun 16, 2016

@enebo Great! Thanks for all the pointers!!

@enebo enebo added this to the JRuby 9.1.3.0 milestone Aug 26, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment