Use Java's Arrays.sort #3961
Merged
Use Java's Arrays.sort #3961
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Java's Arrays.sort more robust and is faster is certain cases. See jruby#3919 and https://github.com/sri/jruby-sort-benchmark.
|
@sri could you re-add the util class and @deprecate it at the top. I do not know if extensions use that class or not but it is public. |
|
@enebo Done! |
|
@sri thanks for the PR and the time taken to show Java's sort has improved! |
|
@enebo Great! Thanks for all the pointers!! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Java's Arrays.sort more robust and is faster is certain cases.
See #3919 and
https://github.com/sri/jruby-sort-benchmark.