New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

help classpath: canonicalization on Windows to fully resolve #4145 #4647

Merged
merged 1 commit into from Jun 6, 2017

Conversation

Projects
None yet
2 participants
@kares
Member

kares commented Jun 5, 2017

has been attempted at cbf9a7d
... using a fake root path, however on Windows /SMT expands as C:\SMT

got a bit inspired by C:/fakepath which browsers use but than I wasn't 100% sure
@headius' previous /THIS_IS_A_FAKE_PATH_FOR_JRUBY is probably a 'safer' bet ?

added '__' at the end so its more obvious if this is slightly off again (classpath:BY\path was confusing)

closes #4630 (also #4645)

help classpath: canonicalization on Windows to fully resolve #4145
has been attempted at cbf9a7d
... using a fake root path, however on Windows /SMT expands as C:\SMT

added '__' at the end so its more obvious if this is slightly off again

closes #4630 (also #4645)
@headius

headius approved these changes Jun 6, 2017

I have no strong opinion on the special path we use. I'll only mention that I included "JRUBY" in it to help localize it specifically to us. I seriously doubt anything will ever overlap the new prefix though.

@headius headius merged commit 6e79faf into jruby:master Jun 6, 2017

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment