Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check meta-class of method objects in `equals` #4918

Merged
merged 1 commit into from Jan 1, 2018

Conversation

Projects
None yet
2 participants
@yui-knk
Copy link
Contributor

yui-knk commented Dec 30, 2017

In MRI, method_eq checks CLASS_OF method objects

(CLASS_OF(method) != CLASS_OF(other))

By this change, TestMethod#test_eq will be passed.

Check meta-class of method objects in `equals`
In MRI, `method_eq` checks CLASS_OF method objects

```
(CLASS_OF(method) != CLASS_OF(other))
```

By this change, `TestMethod#test_eq` will be passed.

@kares kares added the core label Dec 30, 2017

@kares kares added this to the JRuby 9.2.0.0 milestone Jan 1, 2018

@kares

This comment has been minimized.

Copy link
Member

kares commented Jan 1, 2018

nice find - makes sense.

@kares kares merged commit f8fb28d into jruby:master Jan 1, 2018

1 check failed

continuous-integration/travis-ci/pr The Travis CI build could not complete due to an error
Details

@yui-knk yui-knk deleted the yui-knk:test_eq branch Jan 1, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.