Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement Array#prepend and Array#append aliases #4934

Closed
wants to merge 1 commit into from

Conversation

@ChrisBr
Copy link
Contributor

@ChrisBr ChrisBr commented Jan 3, 2018

to support Ruby 2.5, see https://bugs.ruby-lang.org/issues/12746.
#4876

It seems like tests already existed in
spec/ruby/core/array/append_spec.rb and spec/ruby/core/array/prepend_spec.rb

@enebo enebo added this to the JRuby 9.3.0.0 milestone Jan 3, 2018
@enebo
Copy link
Member

@enebo enebo commented Jan 3, 2018

@ChrisBr master is for our upcoming Ruby 2.4 support. Could you submit this PR against the ruby-2.5 branch?

@ChrisBr
Copy link
Contributor Author

@ChrisBr ChrisBr commented Jan 4, 2018

Argh, sorry @enebo ...
Superseded by #4935

@ChrisBr ChrisBr closed this Jan 4, 2018
@enebo enebo modified the milestones: JRuby 9.3.0.0, JRuby 9.2.0.0 Apr 23, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.