-
-
Notifications
You must be signed in to change notification settings - Fork 921
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a CI job for the "sequel" gem #5432
Conversation
Note this should be squashed when merged; there's a lot of fiddling around in there. |
I've added in the remaining environment setup and reduced clone depth to 10. @jeremyevans This is currently running against your master HEAD. Is there a stable branch or tag you'd recommend we use instead? Maybe we query rubygems.org for latest release? |
I'm OK with you running against the master branch. I generally do the same testing locally that Travis does on the latest released version of JRuby, so there is rarely breakage that would be caused by Sequel and not JRuby. That being said, using the latest rubygems.org release is probably safer and will result in fewer false positives. |
* Add a mapping from number to name. * Generate mappings of name to number and number to name once, so we are only iterating the Signal enum in one place. * Omit undefined signals on the current platform. This is how a bad value snuck in for jruby#5432. * Force Windows to always define KILL as 9, even though SIGKILL is not defined on Windows.
@jeremyevans I think we'll just cross that bridge when we come to it. Thanks! |
This PR adds a job based on the CI runs for @jeremyevans Sequel library. I've basically just duplicated his .travis.yml in a shell script that's run along with our other jobs.