Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update specs #5475

Merged
merged 5 commits into from Nov 28, 2018
Merged

Update specs #5475

merged 5 commits into from Nov 28, 2018

Conversation

eregon
Copy link
Member

@eregon eregon commented Nov 27, 2018

Note the tags added in 1dbb3da are due to using the old message (Ruby 2.2) for arity error:

ArgumentError: wrong number of arguments (2 for 1)
instead of
ArgumentError: wrong number of arguments (given 2, expected 1)

(See oracle/truffleruby#1467 for more details)

@eregon eregon requested review from enebo and headius November 27, 2018 20:52
@eregon eregon mentioned this pull request Nov 27, 2018
Closed
@eregon
Copy link
Member Author

eregon commented Nov 28, 2018

Specs are green, merging.

@eregon eregon merged commit f1eaf4c into jruby:master Nov 28, 2018
@eregon eregon deleted the update-specs branch November 28, 2018 12:49
@enebo enebo added this to the Non-Release milestone Nov 28, 2018
@ahorek ahorek mentioned this pull request Dec 3, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@enebo enebo Awaiting requested review from enebo

@headius headius Awaiting requested review from headius

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
Non-Release
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@eregon @enebo