Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Another fix for #5418 #5560

Merged
merged 1 commit into from Jan 17, 2019
Merged

Another fix for #5418 #5560

merged 1 commit into from Jan 17, 2019

Conversation

enebo
Copy link
Member

@enebo enebo commented Jan 16, 2019

No description provided.

@enebo enebo added this to the JRuby 9.2.6.0 milestone Jan 17, 2019
@enebo enebo merged commit 3529448 into master Jan 17, 2019
@kares
Copy link
Member

kares commented Jan 27, 2019

@enebo I am noticing this one as a regression, that likely only reproduces with some ENVs

here's my failing test, since this has been merged, its all green a commit before that :

kares@clevo:~/workspace/oss/jruby$ bin/jruby -Itest test/jruby/test_date.rb 
/home/kares/workspace/oss/jruby/lib/ruby/stdlib/power_assert.rb:7: warning: tracing (e.g. set_trace_func) will not capture all events without --debug flag
Loaded suite test/jruby/test_date
Started
....................................F
=============================================================================================================================================================================================================
Failure: test_time_conv(TestDate)
test/jruby/test_date.rb:565:in `test_time_conv'
     562:   def test_time_conv
     563:     today = Date.today
     564:     assert_equal(today.to_s, Date.today.to_time.strftime('%F'))
  => 565:     assert_equal(today, Date.today.to_time.to_date)
     566: 
     567:     time = DateTime.now
     568:     #assert_equal(nil, time.to_time.zone)
<#<Date: 2019-01-27 ((2458510j,0s,0n),+0s,2299161j)>> expected but was
<#<Date: 2019-01-27 ((2458511j,0s,0n),+0s,2299161j)>>

diff:
? #<Date: 2019-01-27 ((2458510j,0s,0n),+0s,2299161j)>
?                            1                       
=============================================================================================================================================================================================================
........

Finished in 0.704371 seconds.
-------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
45 tests, 1073 assertions, 1 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications
97.7778% passed
-------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
63.89 tests/s, 1523.34 assertions/s

@kares
Copy link
Member

kares commented Jan 27, 2019

and just for the record this passes fine on the CI (at UTC) ... my local-time is CET (GMT+1)

@enebo
Copy link
Member Author

enebo commented Jan 28, 2019

@kares bummer...yeah I wonder if we can see n different timezone also not work or if this is some singular problem?

@kares
Copy link
Member

kares commented Jan 28, 2019

wonder if we can see n different timezone also not work or if this is some singular problem?

do not know but it seems I am getting 1 day off with this change.
it's kind of similar (inverse?) to how #5418 is a problem for -0600 (wout this patch)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants