New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[fix] DateTime (civil) Float sec rounding #5625

Merged

kares merged 1 commit into jruby:master from kares:fix-date-civil-float-sec

Feb 22, 2019

Member

kares commented Feb 22, 2019

noticed a lot of (new) DateTime failures on 2.6 branch from CSV tests
turns out they were all related to sec arg rounding when a Float is given.

this patch will handle such cases ~ as MRI, its not matching C logic but is quite close.


          [fix] DateTime (civil) Float sec rounding

92db749

kares added this to the JRuby 9.2.7.0 milestone

Member Author

kares commented Feb 22, 2019

there seems to be a problem with eql? which fails in some cases (when == passes), looking into that

kares merged commit eaf746b into jruby:master

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet