Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[fix] DateTime (civil) Float sec rounding #5625

Merged
merged 1 commit into from Feb 22, 2019

Conversation

Projects
None yet
1 participant
@kares
Copy link
Member

kares commented Feb 22, 2019

noticed a lot of (new) DateTime failures on 2.6 branch from CSV tests
turns out they were all related to sec arg rounding when a Float is given.

this patch will handle such cases ~ as MRI, its not matching C logic but is quite close.

@kares kares added this to the JRuby 9.2.7.0 milestone Feb 22, 2019

@kares

This comment has been minimized.

Copy link
Member Author

kares commented Feb 22, 2019

there seems to be a problem with eql? which fails in some cases (when == passes), looking into that

@kares kares merged commit eaf746b into jruby:master Feb 22, 2019

1 check failed

continuous-integration/travis-ci/pr The Travis CI build failed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.