Fix typo to combine flags in the parser singleton class rule #6276
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@eregon Thanks for submitting this. I am doing a lot of parser work on a branch and will merge it there (as well as generating new versions of the parsers). If you ever need to generate it you can run ./tool/generate_parser and ./tool/generate_ripper. Leaving it open to make sure I address it. |
|
I added it to my branch which will make it into 9.3/master soonish. I also "upgraded" it to use 0b notation to hopefully help with the intent in 33e3fd7 (as well as generate the .java files). |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See https://github.com/ruby/ruby/blob/46a5d1b4a63f624f2c5c5b6f710cc1a176c88b02/parse.y#L2585
I'm not sure how to regenerate the parser (and ripper maybe), could you do it?