Try not to canonicalize load names before parse #6735
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Fixing this should also fix #5240 but at the moment it does not appear to. The specs expecting symlinked files to appear as-is in e.g. |
This was
linked to
issues
Oct 11, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #5662 we see that the eventual source name used by e.g.
__FILE__should not be the canonicalized name, and should reflect the original load name more closely. On Windows, 8.3 names should not be expanded to full paths, and on unix, symlinks should not be replaced with their referees.This is an experiment to see if a simple change might get the original paths where we want them.