Allow reified classes to store instance variables in raw fields (fixed) #7150
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is principally for making Java integration produce more idomatic Ruby. This allows users to configure a class to store specific ivars in a field of a reified class.
kares
reviewed
Mar 21, 2022
core/src/main/java/org/jruby/runtime/ivars/RawFieldVariableAccessor.java
Outdated
Show resolved
Hide resolved
|
I have confirmed this will be green once merged with my Logger test fixes: https://github.com/jruby/jruby/actions/runs/2022952391 However I can't figure out why this example does not work... where is the field? This seems to mimic the (working) specs so I must be doing something wrong here. Once I understand what I'm doing wrong, this is ready to merge. |
headius
approved these changes
Mar 22, 2022
|
I always run into this too: any usage of the methods that are shared between irb(main):001:0> class Foo < java.lang.Object; java_field "java.lang.String stringField"; end; f = Foo.new; puts f.class.java_class.declared_fields.to_a
private final org.jruby.java.proxies.ConcreteJavaProxy rubyobj.Foo.this$rubyObject
private static final org.jruby.javasupport.proxy.JavaProxyClass rubyobj.Foo.this$rubyProxyClass
private static final org.jruby.javasupport.Java$JCtorCache rubyobj.Foo.this$rubyCtorCache
private static final org.jruby.Ruby rubyobj.Foo.ruby
private static final org.jruby.RubyClass rubyobj.Foo.rubyClass
=> nil
irb(main):002:0> require 'jruby/core_ext'
=> true
irb(main):003:0> class Foo2 < java.lang.Object; java_field "java.lang.String stringField"; end; f = Foo2.new; puts f.class.java_class.declared_fields.to_a
private final org.jruby.java.proxies.ConcreteJavaProxy rubyobj.Foo2.this$rubyObject
private static final org.jruby.javasupport.proxy.JavaProxyClass rubyobj.Foo2.this$rubyProxyClass
private static final org.jruby.javasupport.Java$JCtorCache rubyobj.Foo2.this$rubyCtorCache
private static final org.jruby.Ruby rubyobj.Foo2.ruby
private static final org.jruby.RubyClass rubyobj.Foo2.rubyClass
public java.lang.String rubyobj.Foo2.stringField
=> nil
irb(main):004:0> |
|
@byteit101 Oh boy, that does fix it. Ok, we should do something better than that in the future, but that's not your bug. Let's merge this! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #7012 though now hopefully fixed