Fix public_method_defined in presence of prepend #7577
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When we check
public_method_defined
with no parent search on a prepended class, we go to the location of the class's original methods (methodLocation in JRuby) and do the lookup there. This does find the method, but the original logic then rejected it if the methodLocation was not where the method was originally defined (which of course, it wasn't since the method was originally defined on the non-prepended class). The fix here uses the CacheEntry source module, which should match the new prepended location of the original class's methods.