Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unreachable code #278

Merged
merged 1 commit into from
Dec 3, 2018

Conversation

michaelcameron
Copy link
Contributor

This code creates a warning when consuming js-joda via the google closure compiler.

It's been years since it was reachable and the other places with a similar exception have no implementation below. I know it's ignored for eslint, but as mentioned, it causes warnings in other tool chains.

@coveralls
Copy link

coveralls commented Nov 14, 2018

Coverage Status

Coverage increased (+0.02%) to 92.535% when pulling fbbc32a on michaelcameron:remove-unreachable-code into 767ee7e on js-joda:master.

@pithu
Copy link
Member

pithu commented Nov 19, 2018

Hi @michaelcameron,

Thanks for contributing, your change sounds reasonable, i could merge it right away if you fix the linter error, see https://travis-ci.org/js-joda/js-joda/jobs/455102966

/home/travis/build/js-joda/js-joda/src/Month.js
  13:9   error  'DateTimeFormatterBuilder' is defined but never used  no-unused-vars
  72:20  error  'style' is defined but never used                     no-unused-vars
  72:27  error  'locale' is defined but never used                    no-unused-vars

@michaelcameron
Copy link
Contributor Author

Linter errors have been fixed

@pithu pithu merged commit 8af1100 into js-joda:master Dec 3, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants