Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

empathy.js.org #2870

Merged
merged 1 commit into from
Mar 11, 2019
Merged

empathy.js.org #2870

merged 1 commit into from
Mar 11, 2019

Conversation

the94air
Copy link
Contributor

Copy link
Member

@MattIPv4 MattIPv4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Commit valid, CNAME present, site appears to have content *

* based off https://github.com/the94air/empathy

@MattIPv4 MattIPv4 added add This PR/issue is regarding adding a new subdomain user This PR/issue is regarding a target on a GitHub user account project This PR has a target of a project on an organisation or user account labels Mar 11, 2019
@MattIPv4
Copy link
Member

@indus There may be a concern with this request in that it might be name grabbing? The website has a simple coming soon page that appears to basically be the same as the other active requests from this user?

@indus
Copy link
Member

indus commented Mar 11, 2019

@the94air I have the same feeling like @MattIPv4 . Please add resonable content to the pages you are requesting subdomains for befor we can accept your PRs. Its the same for #2871 & #2872

@the94air
Copy link
Contributor Author

I am just preparing the domains before I publish the projects. I do have the form and empathy project ready (Working on the documentation at the moment before publishing). You can disapprove fun pull request because I don't have it ready yet but I would appreciate leave it so I don't lose the domain. Thank you.

@MattIPv4 MattIPv4 mentioned this pull request Mar 11, 2019
2 tasks
@indus indus added the provisional content This PR currently has limited content on the target and needs to be reviewed at a later time label Mar 11, 2019
@indus
Copy link
Member

indus commented Mar 11, 2019

@the94air based on your comment I decided to approve two of your PRs now. But label them with "provisional content" to make sure to check back on them to see if the requirement of "reasonable content" is fulfilled. So...

Welcome https://empathy.js.org

I will close "fun" for now but feel free to reopen a PR when the content is ready for that page as well. (I would guess that it is highly unlikely that someone else will pick the subdomain in the meantime)

@indus indus merged commit 4301e67 into js-org:master Mar 11, 2019
@indus indus mentioned this pull request Mar 11, 2019
2 tasks
@the94air
Copy link
Contributor Author

That sounds perfect. I sent GitHub a detailed message about the sub-domain issue and I will be committed to solving it. At the meanwhile, I will focus on publishing a reasonable content. Thanks again and have a great day both of you.

@the94air
Copy link
Contributor Author

@indus https://form.js.org/ is up and running. Empathy is still under construction at the moment. You can remove the provisional content flag. Thank you for your patience.

@indus indus removed the provisional content This PR currently has limited content on the target and needs to be reviewed at a later time label Mar 27, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
add This PR/issue is regarding adding a new subdomain project This PR has a target of a project on an organisation or user account user This PR/issue is regarding a target on a GitHub user account
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants