Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

embedded.js.org #8701

Merged
merged 1 commit into from
Dec 7, 2023
Merged

embedded.js.org #8701

merged 1 commit into from
Dec 7, 2023

Conversation

HipsterBrown
Copy link
Contributor

@HipsterBrown HipsterBrown commented Dec 6, 2023

Repo: https://github.com/EcmaTC53/docs
The CNAME file is in the public/ directory at the root of the repository as documented by Astro: https://docs.astro.build/en/guides/deploy/github/
The domain is also set in the GitHub Pages settings for the repo.

@indus indus added add This PR/issue is regarding adding a new subdomain organisation This PR/issue is regarding a target on a GitHub organisation project This PR has a target of a project on an organisation or user account awaiting CNAME This PR is waiting for the target to add a CNAME file labels Dec 6, 2023
@indus
Copy link
Member

indus commented Dec 6, 2023

I've already added your requested subdomain to JS.ORGs zonefile. But because you are using a workflow to deploy the page, additional steps may be required to make the CNAME work.
FYI: #7853 (comment) / #8532 (comment)

@HipsterBrown
Copy link
Contributor Author

@indus Thanks for the links. I've fixed the deployment and it appears to be redirecting correctly! 🚀

@indus
Copy link
Member

indus commented Dec 7, 2023

Welcome https://embedded.js.org

@indus indus merged commit 0f1ed81 into js-org:master Dec 7, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
add This PR/issue is regarding adding a new subdomain awaiting CNAME This PR is waiting for the target to add a CNAME file organisation This PR/issue is regarding a target on a GitHub organisation project This PR has a target of a project on an organisation or user account
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants