Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

izmir.js.org #7885

Closed
wants to merge 2 commits into from
Closed

izmir.js.org #7885

wants to merge 2 commits into from

Conversation

fdemir
Copy link
Contributor

@fdemir fdemir commented Dec 25, 2022

I've updated my community page URL. Thanks for your support.

@MattIPv4 MattIPv4 changed the title update izmir.js.org izmir.js.org Dec 25, 2022
Copy link
Member

@MattIPv4 MattIPv4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi there!

❌ Before we can accept your domain request, you need to create a file named CNAME in the root of your github pages site (this may not be the root of your repository). 📝
This file should contain a single line with the full js.org domain you are requesting, in this instance izmir.js.org.

@MattIPv4 MattIPv4 added the awaiting CNAME This PR is waiting for the target to add a CNAME file label Dec 25, 2022
@fdemir
Copy link
Contributor Author

fdemir commented Dec 25, 2022

Hi there!

❌ Before we can accept your domain request, you need to create a file named CNAME in the root of your github pages site (this may not be the root of your repository). 📝 This file should contain a single line with the full js.org domain you are requesting, in this instance izmir.js.org.

I've already added the CNAME file with the domain. Could you please check it again?

@MattIPv4
Copy link
Member

Hm, it still looks like GitHub hasn't detected it -- have you removed the CNAME file from your old site? And can you check the GitHub Pages settings in the new repo to see if its picking up the custom domain from the CNAME file?

@fdemir
Copy link
Contributor Author

fdemir commented Dec 26, 2022

@MattIPv4

Hi. I removed my old repo with the CNAME file. And I've checked the custom domain at the new repo. It seems all is well.

@MattIPv4
Copy link
Member

Hm okay, if you say so. GitHub isn't serving a redirect like it normally would when the custom subdomain is configured correctly.

@MattIPv4 MattIPv4 added organisation This PR/issue is regarding a target on a GitHub organisation project This PR has a target of a project on an organisation or user account change This PR/issue is regarding making a change to an existing subdomain and removed awaiting CNAME This PR is waiting for the target to add a CNAME file labels Dec 26, 2022
@indus indus added the awaiting CNAME This PR is waiting for the target to add a CNAME file label Dec 26, 2022
@indus
Copy link
Member

indus commented Dec 26, 2022

I've already added your requested subdomain to JS.ORGs zonefile. But you have to remove and re-add the CNAME file to your branch with the single line izmir.js.org to make it work.
I'll merge after we have "contact". Please keep this PR open.

@fdemir
Copy link
Contributor Author

fdemir commented Dec 27, 2022

I did re-add the CNAME file. Check it again pls. I hope this works. I don't see any problem. Why this happens?

@indus
Copy link
Member

indus commented Dec 27, 2022

@fdemir This didn't helped. It looks like there is at least another CNAME with that domain: https://github.com/search?q=izmir.js.org&type=code
As there can only be one, they may be the reason why yours is not working. You may have to ask the Github support for help to remove the others.

@indus
Copy link
Member

indus commented Dec 30, 2022

@fdemir any updates?

@fdemir
Copy link
Contributor Author

fdemir commented Dec 31, 2022

@fdemir any updates?

The first step in addressing this issue is to make sure that your domain is verified for GitHub Pages. This will help to ensure that you have control over the domain and can use it as intended. To verify your domain, you can follow the steps outlined in our help guide:

[Verifying your custom domain for GitHub Pages](https://docs.github.com/en/pages/configuring-a-custom-domain-for-your-github-pages-site/verifying-your-custom-domain-for-github-pages)

If you are no longer planning to use this domain with GitHub Pages, we recommend removing any DNS entries that point the domain towards GitHub, including the GitHub IP addresses. This will help to prevent further issues with domain squatters.

Once the domain has been verified, it will be removed from its current repository in 7 days. However, if you let us know the name of the GitHub account that the verification was made on, we can remove it immediately and save you the wait.

They say this. It is up to you.

@MattIPv4
Copy link
Member

We cannot verify the domain, we are not the ones using it. You need to verify the domain on your account, as you are wanting to use it.

@fdemir
Copy link
Contributor Author

fdemir commented Jan 1, 2023

We cannot verify the domain, we are not the ones using it. You need to verify the domain on your account, as you are wanting to use it.

https://github.com/bugbounty-hunter-1/izmir.js.org This repo uses it. Could it cause the issue?

@MattIPv4
Copy link
Member

MattIPv4 commented Jan 1, 2023

Maybe? You need to follow GitHub's instructions for verifying the domain...

@indus
Copy link
Member

indus commented Jan 6, 2023

@fdemir any updates?

@fdemir
Copy link
Contributor Author

fdemir commented Jan 9, 2023

Could you check it again? I've readd the CNAME file and seems the other repository has been removed. It should work now.

@indus
Copy link
Member

indus commented Jan 9, 2023

@fdemir I still get the 404: https://izmir.js.org

@indus
Copy link
Member

indus commented Jan 11, 2023

@fdemir This is now 2 weeks old. I'll have to close this PR if the issue doesn't resolve. We had problems with pages that use workflows before. But requester figured out what needed to be done to make it work. Maybe this helps: #7853 (comment)

@indus
Copy link
Member

indus commented Jan 15, 2023

@fdemir #7929 this will remove the old domain.

@indus indus closed this Jan 15, 2023
@fdemir
Copy link
Contributor Author

fdemir commented Jan 16, 2023

I know but i should say that i think active_cnames still include the old url.

Old one: https://fdemir.github.io/jsizmir.github.io
New one: https://jsizmir.github.io/landing

I think merging this pr will resolve that issue. What do you think? It is very important to make this page online for our community. Sorry for disturb.

@MattIPv4
Copy link
Member

That file will do nothing, it is just a list for our notekeeping -- [@]indus had the new DNS record in place for two weeks but you did not fix it on your end to make it work. Feel free to open a new PR with the change again if you plan to actually make the change work on your end this time...

@fdemir
Copy link
Contributor Author

fdemir commented Jan 16, 2023

Okay. I am trying to do it. Could you remove the DNS record? GitHub is actually recommended it.

If you are no longer planning to use this domain with GitHub Pages, we recommend removing any DNS entries that point the domain towards GitHub, including the GitHub IP addresses. This will help to prevent further issues with domain squatters.

@MattIPv4
Copy link
Member

As I said, please open a new PR if you want to make changes -- if you want to remove the DNS record, open a PR that removes the entry and we will process it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
awaiting CNAME This PR is waiting for the target to add a CNAME file change This PR/issue is regarding making a change to an existing subdomain organisation This PR/issue is regarding a target on a GitHub organisation project This PR has a target of a project on an organisation or user account
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants