Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

canvasui.js.org #8571

Merged
merged 1 commit into from
Oct 14, 2023
Merged

canvasui.js.org #8571

merged 1 commit into from
Oct 14, 2023

Conversation

devlzl
Copy link
Contributor

@devlzl devlzl commented Oct 13, 2023

I transfer my personal repository to my organization.

Copy link
Member

@MattIPv4 MattIPv4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Commit valid, CNAME present, site appears to have content *

* based off https://github.com/canvasui/docs

@MattIPv4 MattIPv4 added organisation This PR/issue is regarding a target on a GitHub organisation project This PR has a target of a project on an organisation or user account change This PR/issue is regarding making a change to an existing subdomain labels Oct 13, 2023
@indus indus added the awaiting CNAME This PR is waiting for the target to add a CNAME file label Oct 13, 2023
@indus
Copy link
Member

indus commented Oct 13, 2023

I've already changed the subdomain target in JS.ORGs zonefile. But because you are using a workflow to deploy the page, additional steps may be required to make the CNAME work.
FYI: #7853 (comment) / #8532 (comment)

@devlzl
Copy link
Contributor Author

devlzl commented Oct 13, 2023

I've already changed the subdomain target in JS.ORGs zonefile. But because you are using a workflow to deploy the page, additional steps may be required to make the CNAME work. FYI: #7853 (comment) / #8532 (comment)

I've done and it looks good ! Thank you !

@indus indus removed the awaiting CNAME This PR is waiting for the target to add a CNAME file label Oct 14, 2023
@indus
Copy link
Member

indus commented Oct 14, 2023

Welcome back https://canvasui.js.org

@indus indus merged commit d3d3ce6 into js-org:master Oct 14, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
change This PR/issue is regarding making a change to an existing subdomain organisation This PR/issue is regarding a target on a GitHub organisation project This PR has a target of a project on an organisation or user account
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants