Skip to content
This repository has been archived by the owner on Dec 29, 2020. It is now read-only.

Have the config option be loaded using JSCS's loader #37

Closed
mikesherov opened this issue Mar 13, 2014 · 3 comments · Fixed by #38
Closed

Have the config option be loaded using JSCS's loader #37

mikesherov opened this issue Mar 13, 2014 · 3 comments · Fixed by #38
Labels

Comments

@mikesherov
Copy link
Contributor

Right now, despite JSCS being able to parse JSON files with comments (and in the future, YAML files), grunt-jscs-checker can only parse JSON files.

Rather than using grunt.file.readJSON, use jscs/lib/cli-config to load the config.

@mikesherov
Copy link
Contributor Author

@gustavohenke ping. Can you take this one on, or would you like me to do this? It's pretty crucial.

@gustavohenke
Copy link
Member

Yep, I'll do this within 3 hours, work is intense right now.
If you don't want to wait more, tell me, so I'll be waiting for the PR :)

@mikesherov
Copy link
Contributor Author

@gustavohenke no problem. Work first! Just double checking on the status :-) I'll wait till you handle it. Once this is done, can we make a release?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants