Skip to content
This repository has been archived by the owner on Dec 29, 2020. It is now read-only.

Why is the esnext option ignored? #62

Closed
UltCombo opened this issue Oct 23, 2014 · 9 comments
Closed

Why is the esnext option ignored? #62

UltCombo opened this issue Oct 23, 2014 · 9 comments

Comments

@UltCombo
Copy link

Referring to dbb347e

Sure --esnext is buggy, but I believe this plugin should not just silently ignore this option when the user requests to use it.

@UltCombo UltCombo changed the title Why is esnext option ignored? Why is the esnext option ignored? Oct 24, 2014
@gustavohenke
Copy link
Member

Hmmm... well, maybe the commit message wasn't well formed.
We aren't really ignoring it, this array is used to distinct configurations from rules.

Suppose you have the following configuration:

jscs: {
  options: {
    requireCurlyBraces: [ "if" ],
    esnext: true
  },
  src: ".."
}

This way, the requireCurlyBraces is passed as a rule for JSCS while esnext is recognized as an configurable option of JSCS, so no Unsupported rule: foo will happen.

@UltCombo
Copy link
Author

Ohh my bad. Let me run another test to see.

@gustavohenke
Copy link
Member

If you still find it's buggy or is being really ignored, let me know!

@UltCombo
Copy link
Author

@gustavohenke looks like I'm still having issues. I'll try to prepare an isolated test case. =]

@UltCombo
Copy link
Author

@gustavohenke here's a test case:

@gustavohenke
Copy link
Member

It's everything okay with your example.
Seems like we messed up stuff in the latest release.

I'm patching grunt-jscs right now!

@UltCombo
Copy link
Author

Thanks for the quick response. 😃

@gustavohenke
Copy link
Member

Fix landed in v0.8.1!

@UltCombo
Copy link
Author

Thank you very much! :D

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants