-
-
Notifications
You must be signed in to change notification settings - Fork 87
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Docs: add parallel=1
#500
Comments
I ran into this and had some trouble figuring out where exactly to put the command. If you're going to use it inline with the run command, make sure you put it after run and before your nx target:
Here's the other example using this argument within nx.json: Line 27 in 9c2047b
|
@dereekb would you want to contribute on this? |
Sure, why not. I'll work on a small writeup to add to the docs and make a PR. |
i m curious, does this happen all the time? i have seen this happen few times but not sure how to repro it.
and get the following |
I'm still trying to reproduce the issue myself, since it pops up occasionally in my CI even with it inline. Right now I'm having doubts as to whether or not "parallel" changes the behavior at all, or with what runners does it change the behavior, or if it only affects certain commands, such as One possible guess is here:
There might be a race condition with performing concurrent addToStage() since we're using concatMap, so each project is still being updated in parallel. It's hard to reproduce though, but if the changes at addToStage were performed sequentially it might help in my case. In your case, my guess is that the addToStage() from updating the changeLogs and updating the packageJson hit at the same time, since those are also done in parallel:
|
Same behavior like @subhranshudas since v2.23.4 with or without parallel=1 and syncVersions to true. |
Seems like the refactoring to get rid of standard-version introduced this issue, but I'm wondering why e2e tests don't catch anything, I have never seen this error myself. |
it's seems it's coming from the trade between concat and forkJoin operators. |
OK I guess posting this issue helped me on finding the solution!
I just added
parallel=1
to the command.It would be nice to mention this in the documentation as I guess this is a common use case.
Originally posted by @christophediprima in #414 (comment)
The text was updated successfully, but these errors were encountered: