feat: adoption probes #435
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Even though we don't directly test it, the process is trying to connect to the DB during tests. This previously didn't fail only because the timeout was 1 minute and the tests run faster than that:
Now, it fails after I reduced the connection timeout. We need to either prevent this or configure the DB on CI (https://github.com/jsdelivr/data.jsdelivr.com/blob/master/.github/workflows/nodejs.yml#L27-L32). |
MartinKolarik
force-pushed
the
adoption-probes
branch
4 times, most recently
from
4fd1f78
to
2e67778
Compare
MartinKolarik
force-pushed
the
adoption-probes
branch
from
2e67778
to
c344a95
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #425
This functionality requires a connection to MariaDB with the 'adopted_probes' table configured.