Skip to content
This repository has been archived by the owner on Nov 27, 2023. It is now read-only.

breaks when using iphone chrome #15

Closed
cmosguy opened this issue Dec 29, 2015 · 4 comments
Closed

breaks when using iphone chrome #15

cmosguy opened this issue Dec 29, 2015 · 4 comments

Comments

@cmosguy
Copy link

cmosguy commented Dec 29, 2015

Hey @jeffcarp ,

This package is actually a dependency in a few other packages, specifically pwstrength-bootstrap

The problem is when everything is compiled down in es6, etc. (browserify) some browsers do no support the lines you have here:

https://github.com/jsdom/abab/blob/master/index.js#L3

We keep getting an error that says
Uncaught SyntaxError: Use of const in strict mode.

Can you fix this and remove the use of the "const" so that it is compatible?

Thanks!
Adam

@Joris-van-der-Wel
Copy link
Member

You could try using https://github.com/thlorenz/es6ify

@jeffcarp
Copy link
Member

Hi @cmosguy, thanks for bringing this up. I asked about this on Twitter and my current plan is:

  1. Short term: replace const with var
  2. Long term: introduce Babel as a precompile step so we can use ES6 features but publish ES5 to npm

@cmosguy
Copy link
Author

cmosguy commented Dec 30, 2015

Hey @jeffcarp thanks for your quick response. How quickly can you fix this and tag update?

@jeffcarp
Copy link
Member

It's out as 1.0.2!

Changes: 1.0.1...1.0.2

Feel free to re-open if anything comes up!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants