-
-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Minimal implementation to HTMLElement interface #44
Closed
Closed
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -110,10 +110,22 @@ Interface.prototype.generateConstructor = function () { | |
const passArgs = conversions.hasArgs ? ", args" : ""; | ||
this.str += ` | ||
iface.setup(this${passArgs}); | ||
}\n`; | ||
} else if (this.name === 'HTMLElement') { | ||
this.str += `function ${this.name}() { | ||
const { document, customElements } = global.window; | ||
const ownerDocument = window.document[impl]; | ||
let localName = null; | ||
customElements[registry].forEach((Ctor, tagName) => { | ||
if (this.constructor = Ctor) { | ||
localName = tagName; | ||
} | ||
}); | ||
module.exports.setup(this, arguments, { localName, ownerDocument }); | ||
}\n`; | ||
} else { | ||
this.str += `function ${this.name}() { | ||
throw new TypeError("Illegal constructor"); | ||
throw new TypeError('lol this is the DOM not JavaScript ya dummy'); | ||
}\n`; | ||
} | ||
|
||
|
@@ -132,6 +144,10 @@ Interface.prototype.generateRequires = function () { | |
|
||
requireStr += `const impl = utils.implSymbol;\n`; | ||
|
||
if (this.name === 'HTMLElement') { | ||
requireStr += `const registry = utils.registrySymbol;\n`; | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This is used by the changes I've made in jsdom core. |
||
} | ||
|
||
if (this.mixins.length !== 0) { | ||
requireStr += `const mixin = utils.mixin;\n`; | ||
for (let i = 0; i < this.mixins.length; ++i) { | ||
|
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Chrome will auto-detect the environment; I don't know how to do this in jsdom. I'm cheating and using
global.window
which would be set likeglobal.window = jsdomInstance.window
. This is really bad and I want to have it infer directly from jsdom.This is required since you cannot call
new
on a subclassedHTMLElement
that has not been registered with the activeCustomElementsRegistry
.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
hmm, I've run into this myself. I ended up having to add so much crap to simulate the window object I created its own module and would pull it in as a dependency