Skip to content
This repository has been archived by the owner on Jan 24, 2022. It is now read-only.

Update main message #67

Open
dmail opened this issue Jan 7, 2022 · 3 comments
Open

Update main message #67

dmail opened this issue Jan 7, 2022 · 3 comments
Assignees
Labels
good first issue Good for newcomers

Comments

@dmail
Copy link
Member

dmail commented Jan 7, 2022

Actual

Merging worker_importmap into master impact files as follow:

Expected

Impact on file sizes when merging worker_importmap into master.

@dmail dmail assigned dmail and unassigned dmail Jan 7, 2022
@dmail dmail added the good first issue Good for newcomers label Jan 7, 2022
@S0han
Copy link

S0han commented Jan 8, 2022

assign this to me.....please provide me with some clarity as this is not very clear

@dmail dmail assigned dmail and S0han and unassigned dmail Jan 10, 2022
@dmail
Copy link
Member Author

dmail commented Jan 10, 2022

Hello and welcome 👋

More details:

I am not satisfied by the message posted on GitHub pull request (see the violet rectangle on the following image)

file-size-impact:comment_snapshot md at master · jsenv:file-size-impact 2022-01-10 10-04-33

I would like to formulate it differently, maybe something like "Impact on file sizes when merging worker_importmap into master."

The code to update is here

return `<p>Merging <em>${pullRequestHead}</em> into <em>${pullRequestBase}</em> impact files as follow:</p>`

If you want to handle this I would like to have a pull request that I can review.
If you follow the steps below you should be good (I might forgot things):

  • Fork this repository
  • Git clone your fork
  • npm install
  • Do the changes
  • npm run generate-comment-snapshot-file
  • Git add, git commit, git push
  • Open the pull request

@S0han
Copy link

S0han commented Jan 11, 2022

done

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

2 participants