improved readability

jshint · Aug 21, 2014 · 05e1468 · 05e1468
1 parent 8652fdb
commit 05e1468
Showing 1 changed file with 42 additions and 47 deletions.
diff --git a/src/reporters/checkstyle.js b/src/reporters/checkstyle.js
@@ -40,61 +40,56 @@ module.exports =
       if (opts.verbose) {
         errorMessage += ' (' + result.error.code + ')';
       }
+
+      var typeNo = result.error.code;
+      var severity = '';
+      switch(typeNo[0]) {
+        case 'I':
+          severity = 'info';
+          break;
+    	case 'W':
+          severity = 'warning';
+          break;
+        case 'E':
+          severity = 'error';
+          break;
+	  }
 
-        var typeNo = result.error.code;
-        var typeMessages = require('../messages');
-        var message = '';
-        var severity = '';
-        switch(typeNo[0]) {
-            case 'I':
-                message = typeMessages.info[typeNo];
-                severity = 'info';
-                break;
-            case 'W':
-                message = typeMessages.warnings[typeNo];
-                severity = 'warning';
-                break;
-            case 'E':
-                message = typeMessages.errors[typeNo];
-                severity = 'error';
-                break;
-        }
-
-        // Add the error
-        files[result.file].push({
-            severity: severity,
-            line: result.error.line,
-            column: result.error.character,
-            message: errorMessage,
-            source: 'jshint.' + result.error.code
-        });
+      // Add the error
+      files[result.file].push({
+        severity: severity,
+        line: result.error.line,
+        column: result.error.character,
+        message: errorMessage,
+        source: 'jshint.' + result.error.code
+      });
     });
 
 
-      out.push("<?xml version=\"1.0\" encoding=\"utf-8\"?>");
-      out.push("<checkstyle version=\"4.3\">");
+    out.push("<?xml version=\"1.0\" encoding=\"utf-8\"?>");
+    out.push("<checkstyle version=\"4.3\">");
 
-      for (fileName in files) {
-          if (files.hasOwnProperty(fileName)) {
-              out.push("\t<file name=\"" + fileName + "\">");
-              for (i = 0; i < files[fileName].length; i++) {
-                  issue = files[fileName][i];
-                  out.push(
-                      "\t\t<error "+
-                          "line=\"" + issue.line + "\" " +
-                          "column=\"" + issue.column + "\" " +
-                          "severity=\"" + issue.severity + "\" " +
-                          "message=\"" + encode(issue.message) + "\" " +
-                          "source=\"" + encode(issue.source) + "\" " +
-                          "/>"
-                  );
-              }
-              out.push("\t</file>");
-          }
+    for (fileName in files) {
+      if (files.hasOwnProperty(fileName)) {
+        out.push("\t<file name=\"" + fileName + "\">");
+        for (i = 0; i < files[fileName].length; i++) {
+          issue = files[fileName][i];
+          out.push(
+            "\t\t<error " +
+              "line=\"" + issue.line + "\" " +
+              "column=\"" + issue.column + "\" " +
+              "severity=\"" + issue.severity + "\" " +
+              "message=\"" + encode(issue.message) + "\" " +
+              "source=\"" + encode(issue.source) + "\" " +
+              "/>"
+          );
+        }
+        out.push("\t</file>");
       }
+    }
 
     out.push("</checkstyle>");
 
     console.log(out.join("\n"));
   }
-};
+};