Fixed #1174: Fixed a false positive 'destructuring assignment' warning (

closed #1177) Signed-off-by: Anton Kovalyov <anton@kovalyov.net>
jshint · Aug 3, 2013 · 1a3c47f · 1a3c47f
1 parent 303c535
commit 1a3c47f
Show file tree

Hide file tree

Showing 2 changed files with 13 additions and 1 deletion.
diff --git a/src/stable/jshint.js b/src/stable/jshint.js
@@ -4075,7 +4075,7 @@ var JSHINT = (function () {
 				ret.notJson = true;
 				break;
 			}
-			if (_.contains(["}", "]"], pn.value) && pn1.value === "=") {
+			if (_.contains(["}", "]"], pn.value) && pn1.value === "=" && bracketStack === 0) {
 				ret.isDestAssign = true;
 				ret.notJson = true;
 				break;

diff --git a/tests/stable/unit/parser.js b/tests/stable/unit/parser.js
@@ -1196,6 +1196,18 @@ exports["test: destructuring assign of empty values as JS legacy"] = function (t
 	test.done();
 };
 
+exports["test: array element assignment inside array"] = function (test) {
+	var code = [
+		"var a1 = {};",
+		"var a2 = [function f() {a1[0] = 1;}];",
+	];
+
+	TestRun(test)
+		.test(code);
+
+	test.done();
+};
+
 exports["test: let statement as moz"] = function (test) {
 	var code = [
 		"let x = 1;",