[[FIX]] Warn about using var inside for (...) when varstmt: true

Fixes #2627
jshint · Aug 27, 2015 · f1ab638 · f1ab638
1 parent b5ba7d6
commit f1ab638
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 2 deletions.
diff --git a/src/jshint.js b/src/jshint.js
@@ -3610,7 +3610,7 @@ var JSHINT = (function() {
         lone = true;
       }
 
-      if (!prefix && report && state.option.varstmt) {
+      if (!(prefix && implied) && report && state.option.varstmt) {
         warning("W132", this);
       }
 

diff --git a/tests/unit/options.js b/tests/unit/options.js
@@ -2979,7 +2979,8 @@ exports.varstmt = function (test) {
     "var fn = function() {",
     "  var x;",
     "  var y = 5;",
-    "};"
+    "};",
+    "for (var a in x);"
   ];
 
   TestRun(test)
@@ -2988,6 +2989,7 @@ exports.varstmt = function (test) {
     .addError(3, "`var` declarations are forbidden. Use `let` or `const` instead.")
     .addError(4, "`var` declarations are forbidden. Use `let` or `const` instead.")
     .addError(5, "`var` declarations are forbidden. Use `let` or `const` instead.")
+    .addError(7, "`var` declarations are forbidden. Use `let` or `const` instead.")
     .test(code, { varstmt: true });
 
   test.done();