Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Browser variables missing the window constructor: Window #2132

Closed
appden opened this issue Jan 27, 2015 · 3 comments
Closed

Browser variables missing the window constructor: Window #2132

appden opened this issue Jan 27, 2015 · 3 comments
Labels
good first issue P4

Comments

@appden
Copy link

appden commented Jan 27, 2015

I use this to access the window prototype (window.__proto__).
@rwaldron
Copy link
Member

Seems like an easy patch to contribute ;)

mrjoelkemp added a commit to mrjoelkemp/jshint that referenced this issue Aug 5, 2015
@mrjoelkemp
[[FEAT]] Add __proto__ to browser vars
8c3340f 
Adds __proto__ to browser vars to allow window.__proto__ read
only access.

Fixes jshint#2132
@mrjoelkemp mrjoelkemp mentioned this issue Aug 5, 2015
Closed
@mrjoelkemp
Copy link
Contributor

Is this a wont-fix now?

image

npm test fails since proto is deprecated.

@jugglinmike
Copy link
Member

Nope. The original report is for the global variable named Window; the example in the description is a workaround.

mrjoelkemp added a commit to mrjoelkemp/jshint that referenced this issue Aug 7, 2015
@mrjoelkemp
[[FEAT]] Add Window constructor to browser vars
569ba76 
Fixes jshint#2132
@mrjoelkemp mrjoelkemp mentioned this issue Aug 7, 2015
Closed
jugglinmike pushed a commit to jugglinmike/jshint that referenced this issue Sep 20, 2015
@mrjoelkemp @jugglinmike
[[FEAT]] Add Window constructor to browser vars
4e27ef7 
Fixes jshint#2132
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue P4
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@rwaldron @appden @lukeapage @jugglinmike @mrjoelkemp