[[FIX]] Handle multi-line template literal return statements

[caitp]

Closes #1814

[caitp]

@jugglinmike could you review this one? it was the quickest hack i could come up with to support multi-line tokens in return statements

[coveralls]

Coverage increased (+0.0%) to 94.75% when pulling 67d6bef on caitp:issue-1814 into 33612f8 on jshint:master.

[jugglinmike]

Hey Cait! It looks like this is indicative of a larger problem that exists for all multi-line structures:

jshint/src/lex.js

Lines 1377 to 1386 in 33612f8

	// Methods that work with multi-line structures and move the
	// character pointer.
	var match = this.scanComments() ||
	this.scanStringLiteral(checks) ||
	this.scanTemplateLiteral(checks);
	if (match) {
	return match;
	}

For instance, this also fails:

/* jshint multistr: true */
function foo() {
  return 'start\
    end';
};

I know your patch is intended as a quick hack, but what would you say to trying to resolve the problem a bit more generally? Here's what I'm thinking that would look like:

Multiline structures would need to track their last line and first line. I think it would make the most sense to change the current semantics around and have line refer to the first line. A new lastLine property (and maybe lastLineChar?) would be defined for multi-line structures only. (We could also try keeping line behavior as-is and defining a new firstLine property, but I think that would be more confusing.)

Do you think it would be that easy? Or maybe not and better to try in a follow up patch?

[caitp]

@jugglinmike in general, I don't think it is a problem. It is a problem for templates, because a single template token can span multiple lines. But as far as I'm aware, no other token fits that category

[jugglinmike]

@caitp It's also a problem for multi-line string literals.

[caitp]

few extra bits added to work for string literals too... i think this can be generalized more cleanly, but i'll do that in a different patch

[coveralls]

Coverage increased (+0.0%) to 94.75% when pulling c794980 on caitp:issue-1814 into 33612f8 on jshint:master.