Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fail on bad config #691

Closed
valueof opened this issue Oct 12, 2012 · 0 comments
Closed

Fail on bad config #691

valueof opened this issue Oct 12, 2012 · 0 comments
Milestone
1.0.0

Comments

@valueof
Copy link
Member

valueof commented Oct 12, 2012

(OP: @miohtama)

jshint should abort as error if

  • Config file does not exist
  • Config file is not valid JSON

Now it silently ignores config, causing confusion when config flags are not effective.
jugglinmike pushed a commit to jugglinmike/jshint that referenced this issue Oct 21, 2014
@valueof @jugglinmike
Fail early when configuration file can't be found or is invalid.
f1d63f1 
It's confusing when you provide a configuration file using --config
option and it changes nothing. Usually this happens because JSHint
couldn't find your file or the file is not a valid JSON. This commit
makes JSHint to loudly complain about such cases.

Note that this affects only cases when user explicitly provides
a configuration file using --config.

Fixes jshintGH-691.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.0.0
Development

No branches or pull requests
1 participant
@valueof