Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

System errors should have scope too #714

Closed
valueof opened this issue Oct 25, 2012 · 0 comments
Closed

System errors should have scope too #714

valueof opened this issue Oct 25, 2012 · 0 comments
Assignees
@valueof

Comments

@valueof
Copy link
Member

valueof commented Oct 25, 2012

Right now we don't add any scope to system errors such as "Too many errors." one. This is inconsistent with all other error objects and should be fixed.
@ghost ghost assigned valueof Oct 25, 2012
jugglinmike pushed a commit to jugglinmike/jshint that referenced this issue Oct 21, 2014
@valueof @jugglinmike
Add 'scope' property to critical errors.
5275ad7 
Critical errors (those produced by the 'quit' function) show up
in JSHINT.data() as well as any other errors and warnings and
should have the same format.

This patch adds a missing property 'scope' to such errors. It's
always set to '(main)' since errors are unrecoverable.

Fixes jshintGH-714.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@valueof valueof

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@valueof