Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

publish version 1.0.0 to npm #841

Closed
redchair123 opened this issue Feb 1, 2013 · 8 comments
Closed

publish version 1.0.0 to npm #841

redchair123 opened this issue Feb 1, 2013 · 8 comments

Comments

@redchair123
Copy link

The npm version still appears to be 0.9.1

@valueof
Copy link
Member

valueof commented Feb 1, 2013

Once I'm done updating the website I'll publish it. 1.0.0 was tagged, not released.

@valueof valueof closed this as completed Feb 1, 2013
@redchair123
Copy link
Author

@antonkovalyov FYI you can also use semver-style tags in package.json (e.g. 1.0.0-beta or something). I saw the 1.0.0 and assumed that it was a proper release.

@valueof
Copy link
Member

valueof commented Feb 1, 2013

I know that and I used them up until RC4 (tags are still up, you can check them out). And once I was comfortable tagging it as 1.0.0 I changed the package.json version.

@redchair123
Copy link
Author

@antonkovalyov +1 I see that now after looking at the history of package.json

@btipling
Copy link

Kinda weird to have something in master that isn't deployed. At least it's messing with people's expectations and giving you the tedious work of closing issues all the time. 🐟

You could just leave this issue open. Might save you work. 🌠 ⭐ 🌟

@valueof
Copy link
Member

valueof commented Feb 18, 2013

If I deployed master all the time you'd have way more JSHint versions with half of them broken.

@btipling
Copy link

Well the alternative to not deploying master all the time is using branches. A broken master is always bad in general git best practices.

@redchair123
Copy link
Author

@antonkovalyov it might make sense to reopen this so that others see it before submitting more issues.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants