Parse comma expressions. #1084
Merged
Parse comma expressions. #1084
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
usrbincc
commented
May 16, 2013
usrbincc
commented
- Correctly parses the samples from irregular error with comma operator #56, comma operator not understood as single expression #1066, Comma operator still throwing errors (E020 and E030) in valid JS #1083.
- Warns W030: "Expected an assignment or function call and instead saw an expression." when a comma expression is encountered in an expression statement.
- Supersedes pull Handle assignments in 'switch' conditions. #1064, "Handle assignments in 'switch' conditions.".
- Warns W084: "Expected a conditional expression and instead saw an assignment." for assignments at the tail of a comma expression.
- Wrapping in parens now prevents W084.
- Need `{"expr": true}` to allow comma expression statements.
- Assignments are okay if not the comma's final subexpression.
- Remove errors due to misparsing of comma expressions.
- Only the last expression of a comma expression will trigger the warning. - Parens around the entire comma expression will prevent the warning. - Parens around the assignment expression will prevent the warning.
On second thought, the tests for GH-1018 from #1064 might still be good to have. Would it be okay to tack those onto this pull? |
|
Merged and preserved tests for #1018. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.