Updating Checkstyle reporter to provide error codes #1088
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…en --verbose is specified, and changing the source to just provide the error code. The old way of using the raw message was useless, and breaks the categorization in Jenkins
valueof
added a commit
that referenced
this pull request
May 21, 2013
Updating Checkstyle reporter to provide error codes
|
Thanks! |
jugglinmike
pushed a commit
to jugglinmike/jshint
that referenced
this pull request
Oct 21, 2014
Updating Checkstyle reporter to provide error codes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are two goals in this pull request:
result.error.codefor the source, which makes for easy categorizationI would much rather use the name of the actual JSHint option that is causing the error, but this information is not provided to the reporter, so it would take a large amount of refactoring to get that to work. Perhaps we can write a mapping from error code to option, and leverage that to create the source in the future.