Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Catch reserved words in ES3 mode. #1139

Closed
wants to merge 5 commits into from
Closed

Catch reserved words in ES3 mode. #1139

wants to merge 5 commits into from

Conversation

kevnchu
Copy link
Contributor

@kevnchu kevnchu commented Jun 13, 2013

Fix for #1134

Modified behavior of isReserved function to catch using reserved words as properties in ES3 mode. eg. the following code will generate a warning:

var obj = { class: 'foo' };

var obj = {};
obj.protected = 1;

This was referenced Jun 14, 2013
Merged
Closed
@valueof valueof closed this in 9782fc8 Jun 27, 2013
@valueof
Copy link
Member

valueof commented Jun 27, 2013

Thanks!

jugglinmike pushed a commit to jugglinmike/jshint that referenced this pull request Oct 21, 2014
@kevnchu @jugglinmike
Fixed jshint#1134: Catch reserved words in ES3 mode.
e044d23 
Closed jshint#1139.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@kevnchu @valueof