Removed specific gloabals and unused reporting, and fixed jshint warnings. #1305
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…orter. Global and unused errors appear in the normal reporting and are reported twice. This also prohibits suppressing the error with a jshint comment such as // jshint unused: false One error appears even if the above hint is added.
valueof
pushed a commit
that referenced
this pull request
Oct 20, 2013
Signed-off-by: Anton Kovalyov <anton@kovalyov.net>
|
Merged this into 2.x branch, thanks! |
|
Thanks yourself :) Anders On Monday, October 21, 2013, Anton Kovalyov wrote:
|
jugglinmike
pushed a commit
to jugglinmike/jshint
that referenced
this pull request
Oct 21, 2014
Signed-off-by: Anton Kovalyov <anton@kovalyov.net>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now
npm testis passing locally. Sorry about that.