Wrong initialization of the script extraction algorithm #1417
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Wait for a <script> tag before considering that we are in a script.
valueof
pushed a commit
that referenced
this pull request
Dec 13, 2013
Signed-off-by: Anton Kovalyov <anton@kovalyov.net>
valueof
pushed a commit
that referenced
this pull request
Dec 13, 2013
Signed-off-by: Anton Kovalyov <anton@kovalyov.net>
|
Thank you, I've landed your patch both into 2.x and master branches. |
jugglinmike
pushed a commit
to jugglinmike/jshint
that referenced
this pull request
Oct 21, 2014
…itives Signed-off-by: Anton Kovalyov <anton@kovalyov.net>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Right now, the script extraction fails if we have text before the first script tag (ex:
<html><title>foo</title><script>...) because the algorithm thinks it is part of the script.We should wait for the first script tag before extracting scripts. This changes some of the unit tests as well, but
--extract alwaysis basically the equivalent of saying that the input file is an html file (because it is treated like one).