Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "Formal parameter names can be the same as function name. Fixes g... #2037

Merged
merged 1 commit into from Jan 3, 2015
Merged

Revert "Formal parameter names can be the same as function name. Fixes g... #2037

merged 1 commit into from Jan 3, 2015

Conversation

jugglinmike
Copy link
Member

...h-1928"

@rwaldron @caitp For additional context, see my comment from yesterday morning

Commit message:

This reverts commit 248e40b.

The issue which motivated this change related to the modification of the environment record of ES6 concise methods. That issue was addressed in a more comprehensive and concise manner via commit b95f669 and verified with an equivalent unit test.

@caitp
Copy link
Member

caitp commented Dec 16, 2014

I'm offline most of the day due to no power, will take a look in a few hours

@rwaldron
Copy link
Member

rwaldron commented Jan 2, 2015

Please update the commit message to follow https://github.com/jshint/jshint/blob/master/CONTRIBUTING.md#commit-message-guidelines Thanks!!

@jugglinmike
[[FIX]] Revert unnecessary commit
a70bbda 
This reverts commit 248e40b.

The issue which motivated this change related to the modification of the
environment record of ES6 concise methods. That issue was addressed in a
more comprehensive and concise manner via commit
b95f669 and verified with an equivalent
unit test.
@coveralls
Copy link

Coverage Status

Coverage remained the same when pulling a70bbda on jugglinmike:revert-1929 into f46fe40 on jshint:master.

@jugglinmike
Copy link
Member Author

@rwaldon Rebased and re-worded

rwaldron added a commit that referenced this pull request Jan 3, 2015
@rwaldron
Merge pull request #2037 from jugglinmike/revert-1929
030a7c4 
Revert "Formal parameter names can be the same as function name. Fixes g...
@rwaldron rwaldron merged commit 030a7c4 into jshint:master Jan 3, 2015
jugglinmike pushed a commit to jugglinmike/jshint that referenced this pull request Jan 4, 2015
@rwaldron @jugglinmike
Merge pull request jshint#2037 from jugglinmike/revert-1929
5846f45 
Revert "Formal parameter names can be the same as function name. Fixes g...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@jugglinmike @caitp @rwaldron @coveralls