Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update dependencies. #2298

Closed
wants to merge 1 commit into from
Closed

Update dependencies. #2298

wants to merge 1 commit into from

Conversation

XhmikosR
Copy link
Contributor

Note that the new JSCS version fails for indented comments. From a quick look, I couldn't find a fix; any feedback is welcomed.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 96.34% when pulling 5d190cd on XhmikosR:deps into dd768c2 on jshint:master.

1 similar comment
@coveralls
Copy link

Coverage Status

Coverage remained the same at 96.34% when pulling 5d190cd on XhmikosR:deps into dd768c2 on jshint:master.

@XhmikosR
Copy link
Contributor Author

Hmmm, Travis is running a different command than AppVeyor.

@rwaldron @caitp: can we make this consistent? Also, if no one is using coveralls locally, we could skip the devDependency and just install it for CI.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 96.34% when pulling cb721fb on XhmikosR:deps into dd768c2 on jshint:master.

@XhmikosR
Copy link
Contributor Author

@XhmikosR
Copy link
Contributor Author

@rwaldron @caitp: I skipped JSCS for now so that everything passes. I still believe we should run the same command in Travis as AppVeyor (well, maybe except for coverage; no need to duplicate that).

@coveralls
Copy link

Coverage Status

Coverage remained the same at 96.34% when pulling b63f216 on XhmikosR:deps into dd768c2 on jshint:master.

1 similar comment
@coveralls
Copy link

Coverage Status

Coverage remained the same at 96.34% when pulling b63f216 on XhmikosR:deps into dd768c2 on jshint:master.

@XhmikosR
Copy link
Contributor Author

XhmikosR commented May 1, 2015

So, does anybody have any idea how to fix that JSCS error? We can always silence JSCS for those lines as a last resort.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 96.36% when pulling 910fc27 on XhmikosR:deps into b3b41c8 on jshint:master.

1 similar comment
@coveralls
Copy link

Coverage Status

Coverage remained the same at 96.36% when pulling 910fc27 on XhmikosR:deps into b3b41c8 on jshint:master.

Left JSCS to 1.11.x due to issues.
@coveralls
Copy link

Coverage Status

Coverage remained the same at 96.46% when pulling 96fe2ea on XhmikosR:deps into 162e8f7 on jshint:master.

@XhmikosR XhmikosR closed this Jun 20, 2015
@XhmikosR XhmikosR deleted the deps branch June 20, 2015 18:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants