Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: remove unsafe String.to_atom #107

Merged
merged 2 commits into from
Nov 14, 2022
Merged

fix: remove unsafe String.to_atom #107

merged 2 commits into from
Nov 14, 2022

Conversation

thomas9911
Copy link
Contributor

The cron expression parse contained a String.to_atom call which can lead to atom leaks (on arbitrary input)

@maennchen
Copy link
Owner

@thomas9911 Oops, one can see that I wrote this lib when I was new to elixir 😅

@coveralls
Copy link

coveralls commented Nov 14, 2022 •
edited
Loading

Coverage Status

Coverage decreased (-3.0%) to 96.615% when pulling 8fc13c5 on thomas9911:master into 69d20a5 on jshmrtn:master.

@maennchen maennchen enabled auto-merge (squash) November 14, 2022 12:17
@maennchen maennchen merged commit 1ad6e33 into maennchen:master Nov 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maennchen maennchen maennchen approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@thomas9911 @maennchen @coveralls